Skip to content
This repository has been archived by the owner on May 11, 2022. It is now read-only.

Add rate limiting api and refactor credentials #15

Closed
thinkjrs opened this issue May 14, 2020 · 2 comments
Closed

Add rate limiting api and refactor credentials #15

thinkjrs opened this issue May 14, 2020 · 2 comments
Assignees
Labels
client-dev Source code modification documentation Improvements or additions to documentation enhancement New feature or request

Comments

@thinkjrs
Copy link
Member

The current credentials.py and other auth code don't consider rate limiting, which it should. We should implement a means of taking into account:

Header Name Description
X-RateLimit-Limit Number of requests allowed per minute on current plan
X-RateLimit-Remaining Number of requests remaining in current time period (1 minute)
X-RateLimit-Reset Time at which rate limit will reset

as from the docs

@thinkjrs thinkjrs added documentation Improvements or additions to documentation enhancement New feature or request client-dev Source code modification labels May 14, 2020
@thinkjrs
Copy link
Member Author

thinkjrs commented Dec 4, 2020

We should use a decorator our in-development query builder class that monitors the response headers and logs to the user.

@thinkjrs
Copy link
Member Author

thinkjrs commented Feb 6, 2021

Closing here in preference of combining w/Romeo's suggestions in #31.

@thinkjrs thinkjrs closed this as completed Feb 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
client-dev Source code modification documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant