Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dirt_rms ambiguity. should it be running to not? #299

Open
redFrik opened this issue Dec 3, 2023 · 0 comments
Open

dirt_rms ambiguity. should it be running to not? #299

redFrik opened this issue Dec 3, 2023 · 0 comments

Comments

@redFrik
Copy link

redFrik commented Dec 3, 2023

a minor issue...

in DirtOrbit the global effect dirt_rms is loaded and set as .alwaysRun_(true).
but initially it won't run because of a missing default for the rmsReplyRate argument.

the missing argument is found in core-synths-global.scd...
SynthDef("dirt_rms" ++ numChannels, { |gate = 1, dryBus, effectBus, rmsReplyRate, rmsPeakLag, orbitIndex|

changing it to...
SynthDef("dirt_rms" ++ numChannels, { |gate = 1, dryBus, effectBus, rmsReplyRate = 20, rmsPeakLag = 3, orbitIndex|
would make the dirt_rms module run as expected.

thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant