Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relicense under dual MIT/Apache-2.0 #19

Closed
6 of 7 tasks
emberian opened this issue Jan 10, 2016 · 15 comments
Closed
6 of 7 tasks

Relicense under dual MIT/Apache-2.0 #19

emberian opened this issue Jan 10, 2016 · 15 comments

Comments

@emberian
Copy link

This issue was automatically generated. Feel free to close without ceremony if
you do not agree with re-licensing or if it is not possible for other reasons.
Respond to @cmr with any questions or concerns, or pop over to
#rust-offtopic on IRC to discuss.

You're receiving this because someone (perhaps the project maintainer)
published a crates.io package with the license as "MIT" xor "Apache-2.0" and
the repository field pointing here.

TL;DR the Rust ecosystem is largely Apache-2.0. Being available under that
license is good for interoperation. The MIT license as an add-on can be nice
for GPLv2 projects to use your code.

Why?

The MIT license requires reproducing countless copies of the same copyright
header with different names in the copyright field, for every MIT library in
use. The Apache license does not have this drawback. However, this is not the
primary motivation for me creating these issues. The Apache license also has
protections from patent trolls and an explicit contribution licensing clause.
However, the Apache license is incompatible with GPLv2. This is why Rust is
dual-licensed as MIT/Apache (the "primary" license being Apache, MIT only for
GPLv2 compat), and doing so would be wise for this project. This also makes
this crate suitable for inclusion and unrestricted sharing in the Rust
standard distribution and other projects using dual MIT/Apache, such as my
personal ulterior motive, the Robigalia project.

Some ask, "Does this really apply to binary redistributions? Does MIT really
require reproducing the whole thing?" I'm not a lawyer, and I can't give legal
advice, but some Google Android apps include open source attributions using
this interpretation. Others also agree with
it
.
But, again, the copyright notice redistribution is not the primary motivation
for the dual-licensing. It's stronger protections to licensees and better
interoperation with the wider Rust ecosystem.

How?

To do this, get explicit approval from each contributor of copyrightable work
(as not all contributions qualify for copyright, due to not being a "creative
work", e.g. a typo fix) and then add the following to your README:

## License

Licensed under either of

 * Apache License, Version 2.0, ([LICENSE-APACHE](LICENSE-APACHE) or http://www.apache.org/licenses/LICENSE-2.0)
 * MIT license ([LICENSE-MIT](LICENSE-MIT) or http://opensource.org/licenses/MIT)

at your option.

### Contribution

Unless you explicitly state otherwise, any contribution intentionally submitted
for inclusion in the work by you, as defined in the Apache-2.0 license, shall be dual licensed as above, without any
additional terms or conditions.

and in your license headers, if you have them, use the following boilerplate
(based on that used in Rust):

// Copyright 2016 portmidi-rs Developers
//
// Licensed under the Apache License, Version 2.0, <LICENSE-APACHE or
// http://apache.org/licenses/LICENSE-2.0> or the MIT license <LICENSE-MIT or
// http://opensource.org/licenses/MIT>, at your option. This file may not be
// copied, modified, or distributed except according to those terms.

It's commonly asked whether license headers are required. I'm not comfortable
making an official recommendation either way, but the Apache license
recommends it in their appendix on how to use the license.

Be sure to add the relevant LICENSE-{MIT,APACHE} files. You can copy these
from the Rust repo for a plain-text
version.

And don't forget to update the license metadata in your Cargo.toml to:

license = "MIT OR Apache-2.0"

I'll be going through projects which agree to be relicensed and have approval
by the necessary contributors and doing this changes, so feel free to leave
the heavy lifting to me!

Contributor checkoff

To agree to relicensing, comment with :

I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

Or, if you're a contributor, you can check the box in this repo next to your
name. My scripts will pick this exact phrase up and check your checkbox, but
I'll come through and manually review this issue later as well.

@steveklabnik
Copy link
Contributor

I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

1 similar comment
@musitdev
Copy link
Owner

I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

@thenyeguy
Copy link
Contributor

I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

However, it was raised on the rust-portaudio issue that portaudio is licensed MIT only, which might be an issue. If that is an issue, I believe licensing these bindings would have the same issue.

@emberian
Copy link
Author

@thenyeguy yeah, I've been recommending FFI crates like this to split out the -sys and wrapper crates, and license the -sys crate the same as the underlying library (in this case, MIT) and the wrapper as MIT/Apache-2.0. There's no reason you can't license this as MIT/Apache-2.0, but there's not much point to it. The benefit of separate licensing for -sys is that the wrapper code can be freely shared between other MIT/Apache-2.0 repos, and the -sys crate reflects the underlying license for ease of automated licensing compliance tools using cargo metadata.

@samdoshi
Copy link
Collaborator

I'll wait to see what happens in RustAudio/rust-portaudio#115 before deciding what to do.

Also, truthfully, I don't really use rust that much any more, don't really have the time, so if someone wishes to step up and take over maintenance of this crate...

@suhr
Copy link
Contributor

suhr commented Jan 11, 2016

Sure.

@irh
Copy link
Contributor

irh commented Jan 11, 2016

I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

@musitdev
Copy link
Owner

Hello I can get back the maintenance of the create. I don't have much time but I work with it currently. I think there isn't much work to follow the evolution of Rust.

@samdoshi
Copy link
Collaborator

Repo transfer request sent, once you accept I'll add you as an owner on crates.io

@samdoshi
Copy link
Collaborator

@musitdev You'll need to make an account on crates.io...

$  cargo owner --add musitdev
    Updating registry `https://github.com/rust-lang/crates.io-index`
       Owner adding ["musitdev"] to crate portmidi
failed to add owners to crate portmidi: api errors: could not find user with login `musitdev`

@samdoshi
Copy link
Collaborator

I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

@emberian
Copy link
Author

Awesome! Glad to see this crate continue to be maintained.

@musitdev
Copy link
Owner

It's done, I've autorise cargo.io to github.

@samdoshi
Copy link
Collaborator

@musitdev I've added you as an 'owner'

@musitdev
Copy link
Owner

Ok, thank you @samdoshi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants