Refine summary #105
Merged
Refine summary #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
musoke
commented
May 31, 2022
musoke
commented
- fix some subtle bugs in summary extensions
- add more possible summary outputs
Some internal functions their associated types in the `Summary` module have misleading names. Rename them.
The docs claim that you can dispatch `Summary.column_title` on the
datatype to output multiple values from a summary type. This isn't
true; Julia doesn't allow dispatch on value.
Change the signature of `Summary.column_title` to fix this; now can
dispatch on the type of Val{SummaryType}.
Add a summary that captures the maximum density and its location.
musoke
force-pushed
the
refine_summary
branch
3 times, most recently
from
7cdbb40
to
5a4740b
Compare
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
==========================================
- Coverage 87.75% 87.27% -0.48%
==========================================
Files 8 8
Lines 449 495 +46
==========================================
+ Hits 394 432 +38
- Misses 55 63 +8
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.