fix: Correct scale factor on last half step #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #127 +/- ##
=======================================
Coverage 83.39% 83.39%
=======================================
Files 8 8
Lines 560 560
=======================================
Hits 467 467
Misses 93 93
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There is a missing `; a = a(t)` in the argument to `outer_step!` that does the closing half step. This is never an issue if there is no background expansion. Add it in. This should maybe not be an optional argument; it shouldn't be possible to accidentally call with the wrong `a(t)`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a missing
; a = a(t)in the argument toouter_step!that does the closing half step. This is never an issue if there is no background expansion.Add it in.
This should maybe not be an optional argument; it shouldn't be possible to accidentally call with the wrong
a(t).