FIX #57 #59
Merged
FIX #57 #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 8, 2017 19:22
Added a new method ExifUtils.readMetaDataAsTable which return a lua table with all exif keys and values Adapted ExfiUtils.findFirstMatchingValue accordingly
| local value = nil | ||
|
|
||
| for key,keyword in pairs(keys) do | ||
| value = ExifUtils.findValue(metaData, keyword) | ||
| for key, keyword in pairs(keys) do |
There was a problem hiding this comment.
nit:
this is typically a "key -> value" loop similar to a HashMap. Mind calling k,v or key, value (and renaming the prop on line 74)?
| value = ExifUtils.findValue(metaData, keyword) | ||
| for key, keyword in pairs(keys) do | ||
| value = metaDataTable[keyword] | ||
| if value == nil then |
There was a problem hiding this comment.
can we simplify this and remove the logging ifs
if value ~= nil and value ~= "(none)" then
return value
end
There was a problem hiding this comment.
what do you want me to simplify there ?
There was a problem hiding this comment.
it's fine. you can keep the log if you really want it.
|
nice work. Great use of a branch |
|
approved. will give you time to push/respond if you want before i merge. |
|
merged. nice work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new method ExifUtils.readMetaDataAsTable which return a lua
table with all exif keys and values
Adapted ExfiUtils.findFirstMatchingValue accordingly
Removed unneeded methods