Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor metadata to be a table rather than a string #57

Closed
musselwhizzle opened this issue Jan 9, 2017 · 3 comments
Closed

Refactor metadata to be a table rather than a string #57

musselwhizzle opened this issue Jan 9, 2017 · 3 comments

Comments

@musselwhizzle
Copy link
Owner

Currently the metadata is read from a file and returned as a string. Any method that then needs the metadata must create it's own table from it. Instead, in DefaultPointsRenderer, convert this string into a table of key, value pairs and store it. (Note, dont do this in the metadata viewer as converting to a table will throw out duplicate key names). The metadata table (and not string) should then be passed to methods and not the string metadata.

E.g.

local metadata = {}
metadata["AF Point"] = "C6"
metadata["Focal Length"] = "30mm"
@rderimay
Copy link
Contributor

rderimay commented Jan 9, 2017

ok 'll take it

rderimay pushed a commit to rderimay/Focus-Points that referenced this issue Jan 9, 2017
Added a new method ExifUtils.readMetaDataAsTable which return a lua
table with all exif keys and values
Adapted ExfiUtils.findFirstMatchingValue accordingly
@rderimay
Copy link
Contributor

rderimay commented Jan 9, 2017

PR #59

@musselwhizzle
Copy link
Owner Author

awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants