added template inheritance

[csingewald]

I added template inheritance as proposed in mustache/spec#38. There where problems using the '$' sign in the parser thats why I chose the '%'. The '$' sign would be a better choice.

[locks]

Thank you! I'll review it in the weekend and get back to you.

[locks]

Please don't change the version number.
I'll bump it previous to releases, it makes it easier to track.

[locks]

You can ignore the comments apart from the version number one, that one I would appreciate if you could make the change.

[bobthecow]

Using % as the block sigil might be a deal-breaker, since a large part of the reason people choose mustache is that it works in multiple environments. Template inheritance has already been implemented in Java, JavaScript, Objective-C and PHP (at least) using the $ sigil.

What sort of problems were you running into? Was it a regular expression issue?

[locks]

Thanks @bobthecow, I actually meant to ask that but seems I forgot.

[csingewald]

Thank you for the review, I am still learning a lot. I startet with ruby only a few weeks ago. I pushed the changes.
Using the $ sign parsing the template failed sometimes. It seemed not to be deterministic. Inside the parser method 'scan_tag_close' the prematch was sometimes nil. I could not figure out why.

[locks]

Hi @singy.

Like @bobthecow mentioned, it's a problem if this implementation uses a different sigil (% instead of $) from the other implementations for template inheritance.

I tried but couldn't figure out what exactly is making the tests not pass if we use $. If you have the time I'd appreciate your help so we can finish this :)

[bobthecow]

Also, {{%PRAGMA}} is used for pragmas, and while the ruby implementation doesn't currently have any pragmas, it has in the past, and probably should have one for this change, since it isn't strictly spec compliant :)

[ghost]

What is the problem with using $, is it anything to do with the way it compiles to a Ruby string? What's failing?

[csingewald]

I agree with you, the '$' sign ist the way to go. I changed the source. One test fails, maybe I am wrong and this test is erroneous.

https://github.com/singy/mustache/commit/f81e9b1b7c29cadb3c64522785c5de5d3bc8e96e

[locks]

@singy well this is confusing. Travis reports 3 errors, I'm getting 4 locally, and you get only 1 xD
What Ruby version are you running?

mine: ruby-2.1.2
travis: 2.1.0p0 https://travis-ci.org/mustache/mustache/jobs/50105158#L126

[locks]

Interesting, I get two errors if I run rake test instead of bundle exec rake test.

It's order-dependent, varying between 1 and 4 errors. This exposes a problem somewhere in the codebase.

[locks]

Issue found: Unused method argument - padding. If it's necessary, use _ or _padding as an argument name to indicate that it won't be used.

[locks]

Issue found: Inconsistent indentation detected.

[homu]

☔ The latest upstream changes (presumably #220) made this pull request unmergeable. Please resolve the merge conflicts.

[ghost]

For anyone wanting template inheritance/layouts until this patch is accepted, I have implemented it I'm my Ruby Mustache implementation called Tache and am using it in production.