Treat empty strings as falsey values #210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mustache was treating empty strings both as truthy and falsey values. This change resolves the inconsistency, but also brings Mustache's behavior more in line with Mustache.js's.
|
👎 Empty strings are truthy in ruby, so they should be truthy in ruby mustache. (The truthiness duality issue should be fixed, but it should be changed so that empty strings are consistently truthy, not consistently falsey). |
|
☔ The latest upstream changes (presumably #220) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Hi, I'm closing this PR because this would not be following the spec, like mentioned by @bobthecow. |
|
@boblail I would welcome a new PR with the change mentioned, thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mustache was treating empty strings both as truthy and falsey values.
This change resolves the inconsistency, but also brings Mustache's behavior more in line with Mustache.js's.
This resolves issue #206