New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement `Mustache#escape` #245

Merged
merged 1 commit into from Oct 13, 2018

Conversation

Projects
None yet
1 participant
@locks
Copy link
Member

locks commented Oct 3, 2018

Mustache currently has a Mustache#escapeHTML method that can be overriden to customize the escaping of the values of {{}}. Given that the escaping does not necessarily have to be HTML, a more generic Mustache#escape will be added.

Technical approach

  • Introduce Mustache#escape that defaults to Mustache#escapeHTML
  • Deprecate Mustache#escapeHTML

@locks locks self-assigned this Oct 3, 2018

@locks locks force-pushed the feat/escaping-option branch from 96fc5a5 to 6033c22 Oct 13, 2018

@locks locks force-pushed the feat/escaping-option branch from 6033c22 to 61d5fb6 Oct 13, 2018

@locks locks merged commit a72cde3 into master Oct 13, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@locks locks deleted the feat/escaping-option branch Oct 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment