Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#34 Sentiment Analysis Backend #70

Merged
merged 32 commits into from
Mar 22, 2024
Merged

Conversation

BasicallyOk
Copy link
Collaborator

@BasicallyOk BasicallyOk commented Mar 4, 2024

What does this PR do?

Providing the solution to #34 mainly. The experiences will be evaluated and changed over time as more submissions are added. Allowing users to find out how many people shares similar experiences as them. Also allow researchers a way to identify trends.

The ticket will also include a script to seed the database with Erowid submissions. This is clutch for testing analytics and researcher-centric functionalities.

Github Issue Number

Resolves: #34 #68 #71 #72 (turns out I can get it done pretty quick)

Relates to: Potentially #72, but that ticket will probably warrant its own PR due to the size of the rework involved.
#69 (nice, but I forgot about it, not nice, next pr it is)

Author checklist

If any of these points have yet to be satisfied, make sure that you set the title to the format DRAFT #issue-num Title

  • The title is short and descriptive of the PR. Must start with the Github Issue Number (format: #issue-num Title).
  • The description follows proper cl description practices and mentions related Github Issues (make sure this is the first thing you mention).
  • Branch has merged in the latest version of main
  • Linting has occured, as per the project linting config
  • All changed functions have proper docstring/wiki updates (front-end team) to describe what they do and how to use them.
  • Add yourself as the assignee.
  • Add reviewer a reviewer and let them know on discord.
  • Ensure that all relevant ticket has been linked to the PR

Reviewer checklist

  • Relevant issue is mentioned in description
  • Code solves the issue
  • Code follows the specification
  • Code is the best solution for the issue
  • Branch is ahead of main
  • Ensures the fix/feature works locally (docker compose up --build)

@BasicallyOk BasicallyOk self-assigned this Mar 4, 2024
@BasicallyOk BasicallyOk linked an issue Mar 4, 2024 that may be closed by this pull request
This was linked to issues Mar 4, 2024
@BasicallyOk BasicallyOk added bug Something isn't working enhancement New feature or request labels Mar 4, 2024
@BasicallyOk BasicallyOk linked an issue Mar 4, 2024 that may be closed by this pull request
@BasicallyOk BasicallyOk mentioned this pull request Mar 11, 2024
@BasicallyOk BasicallyOk changed the title DRAFT #34 Sentiment Analysis Backend #34 Sentiment Analysis Backend Mar 21, 2024
Copy link
Owner

@mustafa-tariqk mustafa-tariqk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

address changes and we should be good to go. I hate you for making this PR so huge

client.html Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this file? does it need to exist?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this file as well?

@mustafa-tariqk mustafa-tariqk merged commit 6298412 into main Mar 22, 2024
1 check passed
@mustafa-tariqk mustafa-tariqk deleted the 34-sentiment-analysis-backend branch March 25, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
2 participants