-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #171. Fix Park's correction to the relaxation time. #199
Closes #171. Fix Park's correction to the relaxation time. #199
Conversation
Codecov Report
@@ Coverage Diff @@
## master #199 +/- ##
=======================================
Coverage 71.22% 71.22%
=======================================
Files 135 135
Lines 8972 8974 +2
=======================================
+ Hits 6390 6392 +2
Misses 2582 2582
Continue to review full report at Codecov.
|
Hey @mgoodson-cvd, this is a great catch, thank you! I think it would make sense to actually move the calculation of sigma into the |
@jbscoggi That makes sense. Quick question on nomenclature and implementation -- right now you have a getter and setter for |
Hey @mgoodson-cvd, sorry I didn't realize you replied the other day. I think the temperature scaled version is the actual limiting cross section, so let's call the setter something like |
Fix Park's correction to the relaxation time. The temperature term was inadvertently removed in bc9ce81. Modifies the existing `limitingCrossSection` routine to take the temperature as an argument to scale the reference cross section. See mutationpp#171. Closes mutationpp#171.
Update Millikan-White unit test to include the fixes for the Park correction. Now checks both the reference and limiting cross sections. See mutationpp#171.
f16273a
to
f5a7f2c
Compare
@jbscoggi How's this look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks a lot.
Fix Park's correction to the relaxation time.
The temperature term was inadvertently removed in bc9ce81.
Also updates the unit test for Millikan-White.
See #171. Closes #171.