Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reference updating code to update references immediately rather than on separate thread #10

Closed
zelerin opened this issue Feb 28, 2019 · 0 comments · Fixed by #47
Closed
Assignees
Labels
bug Something isn't working

Comments

@zelerin
Copy link
Member

zelerin commented Feb 28, 2019

Currently, when an Entity changes what room it is in, this updates the references attribute on the room it has left and entered. This is normal, however currently the updating is done on the DB update thread which only polls every 3 seconds. This can cause situations like entering a room but no one can look at you for several seconds, or dropping/getting something and not seeing it for a few seconds.

The solution should be as simple as refactoring the reference updating code to execute immediately, in the same thread of control as the Entity being updated, rather than pulling the request later off a queue.

@zelerin zelerin added the bug Something isn't working label Feb 28, 2019
@zelerin zelerin self-assigned this Sep 3, 2019
zelerin added a commit that referenced this issue Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant