Break down operators.py into multiple Python modules #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Can I merge it? |
|
Yes 👍 |
b-price
pushed a commit
to b-price/mojomutpy
that referenced
this pull request
Mar 14, 2024
Handle annotated assignment in 3.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CodeClimate complains that operators.py is too long (567 lines of code (exceeds 250 allowed)).
So I took a look at it and found out that the operators can be grouped together like arithmetic, logical, decorator etc. So I created a Python module for each group and put each operator into the most fitting file.
Thanks to some init.py magic no import statements outside of operators had to be changed.
Edit: CodeClimate fails for this PR because by moving code I also moved some code smell issues between files. CC thinks I created new smells, but they are the old ones in another file. Long story short: CC can be safely ignored this time :-D