Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Head Tracker sensor #55

Merged
merged 7 commits into from
Apr 25, 2023
Merged

Support for Head Tracker sensor #55

merged 7 commits into from
Apr 25, 2023

Conversation

Chandra-Mauli-Sharma
Copy link
Contributor

In ref. to #38.

The support for the Head Tracker sensor is added.

@Chandra-Mauli-Sharma Chandra-Mauli-Sharma changed the base branch from main to development April 25, 2023 09:44
@shubhamsinghmutualmobile
Copy link
Collaborator

@Chandra-Mauli-Sharma Could you please also add a screenshot/recording showcasing that the implementation is working fine on a device (be it an emulator or a physical device)?

@shubhamsinghmutualmobile shubhamsinghmutualmobile added the enhancement New feature or request label Apr 25, 2023
@Chandra-Mauli-Sharma
Copy link
Contributor Author

@Chandra-Mauli-Sharma Could you please also add a screenshot/recording showcasing that the implementation is working fine on a device (be it an emulator or a physical device)?

It was not working on my phone or emulator. I tried it on Pixel 7 but it was not supported in that too.

I also found this in the documentation: https://developer.android.com/reference/android/hardware/Sensor#TYPE_HEAD_TRACKER

image

@shubhamsinghmutualmobile shubhamsinghmutualmobile linked an issue Apr 25, 2023 that may be closed by this pull request
Head Tracker sensor implementation #38
Closed
@shubhamsinghmutualmobile
Copy link
Collaborator

Whenever we raise a PR that fixes an issue, it's good to use the closing keywords like (fixes #IssueNumber, or resolves #IssueNumber). It automatically connects our PR to that issue so that whenever our PR is merged, that issue is also closed ✅ (Click here for more info)

@shubhamsinghmutualmobile shubhamsinghmutualmobile merged commit dd9961a into mutualmobile:development Apr 25, 2023
@Chandra-Mauli-Sharma
Copy link
Contributor Author

Chandra-Mauli-Sharma commented Apr 25, 2023 •
edited
Loading

Thanks for the info. It means a lot, next time I will take care.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubhamsinghmutualmobile shubhamsinghmutualmobile shubhamsinghmutualmobile approved these changes

Assignees

@Chandra-Mauli-Sharma Chandra-Mauli-Sharma

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Head Tracker sensor implementation
2 participants
@Chandra-Mauli-Sharma @shubhamsinghmutualmobile