Bug in supporting primary key at non-root keypath in response dictionary #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome catch. Thanks!!! |
cnstoll
added a commit
that referenced
this pull request
May 3, 2013
Bug in supporting primary key at non-root keypath in response dictionary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conrad,
After debugging what we discussed yesterday a bit, I think I found the last root of the issue (after fixing the setup problems on my end :). In
MMRecordRepresentationwhen it looks for the primary key of the response, it's usingvalueForKey:rather thanvalueForKeyPath:so our response wasn't getting mapped correctly to the existing record. In the testing I've done so far, the content of this PR seems to be enough to get us up and running.Your thoughts?
john