New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deployment of basic features #1
Conversation
Rendered webpage with connection status and MPTCP version if established. | ||
""" | ||
|
||
addr = request.remote_addr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how does it display a v6 address? In ss
, it surrounds it with []
, you might need to handle that.
(to check if it is a v6 address, simply look for :
in the address)
# print() | ||
return render_template('index.html', state_message=state_message, state_class=state_class) | ||
|
||
@app.route('/stream_audio') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do you need this? Just to have a file to download?
You will need to put the license and the source somewhere to avoid troubles... (even if we can use it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the download of a file usefull? can the same effect be achieved with a large binary file or something similar?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the same can be achieved with large binary files generated with 'dd' with random data (not just zeros). So flask should not be needed for that part. Probably best to disable compression support in lighttpd like GZip.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe easier to add files in a dedicated directory: 1M, 10M, 100M, 1G?
@mux99 @CrapsDorian : if it is easy to do, it might be good to have a specific reply when curl is used, e.g. by checking if the user-agent starts with That's what we have when we do a |
protocol was missing form config, causing server to use the wrong one by default
We still need to check if it works in IPv6. |
And the service should not stop, but be detached. |
this PR as for objective to simply add the basic functionality of the app
to be noted: