fix: disable if tts gets too long #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevmo314
requested changes
Jan 19, 2024
kevmo314
reviewed
Jan 22, 2024
jessielw
approved these changes
Feb 8, 2024
kevmo314
requested changes
Feb 8, 2024
refactor: setup ttsChannel to be a getter, defaulting to true
…branch now and allows the build to compile
…late listens to changes in this stream
refactor: import main.dart to enable channel swapping via it's function updateChannelSubscription fix: queued text to speech not working correctly
…ted before going to the next item in the queue fix: fixed an error where it would sometimes delete the item that was next in queue feat: create a ttsqueueelement class to be used throughout our main queue class as needed fix: disabling of text to speech when messages are greater than 20
kevmo314
approved these changes
Feb 23, 2024
There was a problem hiding this comment.
Nice, code looks good. @SputNikPlop can you verify and test?
Co-authored-by: Kevin Wang <kevmo314@gmail.com>
Co-authored-by: Kevin Wang <kevmo314@gmail.com>
Co-authored-by: Kevin Wang <kevmo314@gmail.com>
Co-authored-by: Kevin Wang <kevmo314@gmail.com>
jessielw
approved these changes
Feb 23, 2024
SputNikPlop
commented
Feb 23, 2024
kevmo314
approved these changes
Feb 26, 2024
This was referenced Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disabled tts if the queue gets too long.