fix: enable cast docs + cast fix #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## main #253 +/- ##
=======================================
Coverage 80.75% 80.75%
=======================================
Files 36 36
Lines 4297 4297
Branches 153 152 -1
=======================================
Hits 3470 3470
Misses 818 818
Partials 9 9 |
luwes
changed the title
luwes
commented
Jun 15, 2022
| @@ -25,6 +25,10 @@ const CastableVideoMixin = (superclass) => | |||
| return CastableVideo.#castEnabled; | |||
| } | |||
|
|
|||
| static get castState() { | |||
| return CastableVideo.#castContext?.getCastState(); | |||
| } | |||
There was a problem hiding this comment.
fix needed by media-chrome
1 task
cjpillsbury
reviewed
Jun 22, 2022
| @@ -62,6 +63,7 @@ function MuxPlayerPage() { | |||
| > | |||
| <h1>MuxPlayer Demo</h1> | |||
| <div> | |||
| <Script src="https://www.gstatic.com/cv/js/sender/v1/cast_sender.js?loadCastFramework=1" /> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds some docs to enable casting on the player.
moved the big wall of props/attrs/methods/events to be last in the readme.
unveiled 1 cast bug where the button would not show on SPA navigation in the Next.js app