Feat/expose control props #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## main #332 +/- ##
==========================================
- Coverage 80.83% 80.25% -0.59%
==========================================
Files 38 38
Lines 4722 4800 +78
Branches 154 156 +2
==========================================
+ Hits 3817 3852 +35
- Misses 896 939 +43
Partials 9 9
|
cjpillsbury
commented
Aug 11, 2022
packages/mux-player/src/template.ts
Outdated
| @@ -80,6 +80,8 @@ export const content = (props: MuxTemplateProps) => html` | |||
| default-hidden-captions="${props.defaultHiddenCaptions}" | |||
| forward-seek-offset="${props.forwardSeekOffset}" | |||
| backward-seek-offset="${props.backwardSeekOffset}" | |||
| playbackrates="${props.playbackRates ?? false}" | |||
| hide-duration="${props.hideDuration ?? false}" | |||
There was a problem hiding this comment.
note: This was another case of attributes vs. props from getProps stepping on toes, where, even for a boolean, I have to handle this with nullish coalescing.
luwes
reviewed
Aug 15, 2022
luwes
reviewed
Aug 15, 2022
luwes
reviewed
Aug 15, 2022
cjpillsbury
force-pushed
the
feat/expose-control-props
branch
from
9475433
to
2388bdb
Compare
luwes
reviewed
Aug 24, 2022
cjpillsbury
force-pushed
the
feat/expose-control-props
branch
2 times, most recently
from
c34a929
to
8d6dd35
Compare
gkatsev
approved these changes
Aug 24, 2022
…types to use a generic component type.
…rops and attrs plus general readme cleanup.
…ttributeChangedCallback for time-display.
… to attribute for duration.
cjpillsbury
force-pushed
the
feat/expose-control-props
branch
from
40dc14f
to
8e7024f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding props & attributes to mux player react to support configurable:
Also pre-reqs for this PR:
This is based on current goals for control customization.