Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(playback-core, mux-video, mux-player): addChapters interface #909

Merged
merged 31 commits into from
May 21, 2024
Merged

feat(playback-core, mux-video, mux-player): addChapters interface #909

merged 31 commits into from
May 21, 2024

Commits on May 17, 2024

  1. interface for setting and getting chapters

    @AdamJaggard
    AdamJaggard committed May 17, 2024
    Configuration menu
    Copy the full SHA
    e0ca84f View commit details
    Browse the repository at this point in the history

  2. fix method name

    @AdamJaggard
    AdamJaggard committed May 17, 2024
    Configuration menu
    Copy the full SHA
    061d853 View commit details
    Browse the repository at this point in the history

  3. track kind "chapters"

    @AdamJaggard
    AdamJaggard committed May 17, 2024
    Configuration menu
    Copy the full SHA
    8d31ba6 View commit details
    Browse the repository at this point in the history

  4. align track attributes with how media store locates text tracks for c… 

    …hapter info
    @AdamJaggard
    AdamJaggard committed May 17, 2024
    Configuration menu
    Copy the full SHA
    4b6a48d View commit details
    Browse the repository at this point in the history

  5. undo space change

    @AdamJaggard
    AdamJaggard committed May 17, 2024
    Configuration menu
    Copy the full SHA
    0016ae6 View commit details
    Browse the repository at this point in the history

  6. chapters example in vanilla

    @AdamJaggard
    AdamJaggard committed May 17, 2024
    Configuration menu
    Copy the full SHA
    6c4af58 View commit details
    Browse the repository at this point in the history

  7. cuepoints -> chapters

    @AdamJaggard
    AdamJaggard committed May 17, 2024
    Configuration menu
    Copy the full SHA
    f03d9c3 View commit details
    Browse the repository at this point in the history

  8. easier to read

    @AdamJaggard
    AdamJaggard committed May 17, 2024
    Configuration menu
    Copy the full SHA
    c2480ac View commit details
    Browse the repository at this point in the history

  9. undoing this, it wasn't needed

    @AdamJaggard
    AdamJaggard committed May 17, 2024
    Configuration menu
    Copy the full SHA
    efc0bd2 View commit details
    Browse the repository at this point in the history

  10. force mode change to cause a change event

    @AdamJaggard
    AdamJaggard committed May 17, 2024
    Configuration menu
    Copy the full SHA
    f881819 View commit details
    Browse the repository at this point in the history

  11. forced mode flipping to use "showing" instead of "disabled"

    @AdamJaggard
    AdamJaggard committed May 17, 2024
    Configuration menu
    Copy the full SHA
    0ab2660 View commit details
    Browse the repository at this point in the history

  12. tests

    @AdamJaggard
    AdamJaggard committed May 17, 2024
    Configuration menu
    Copy the full SHA
    e88926b View commit details
    Browse the repository at this point in the history

  13. remove unimplemented event

    @AdamJaggard
    AdamJaggard committed May 17, 2024
    Configuration menu
    Copy the full SHA
    bb362f6 View commit details
    Browse the repository at this point in the history

  14. nextjs example

    @AdamJaggard
    AdamJaggard committed May 17, 2024
    Configuration menu
    Copy the full SHA
    43c7ff1 View commit details
    Browse the repository at this point in the history

  15. optional end time for chapters

    @AdamJaggard
    AdamJaggard committed May 17, 2024
    Configuration menu
    Copy the full SHA
    7007542 View commit details
    Browse the repository at this point in the history

  16. cuepoints with similar shape to chapters, supporting legacy type

    @AdamJaggard
    AdamJaggard committed May 17, 2024
    Configuration menu
    Copy the full SHA
    5f24490 View commit details
    Browse the repository at this point in the history

  17. updated types

    @AdamJaggard
    AdamJaggard committed May 17, 2024
    Configuration menu
    Copy the full SHA
    bdf3a59 View commit details
    Browse the repository at this point in the history

  18. update reference

    @AdamJaggard
    AdamJaggard committed May 17, 2024
    Configuration menu
    Copy the full SHA
    6127b49 View commit details
    Browse the repository at this point in the history

  19. use audio UI for second example

    @AdamJaggard
    AdamJaggard committed May 17, 2024
    Configuration menu
    Copy the full SHA
    e6ba018 View commit details
    Browse the repository at this point in the history

  20. remove else

    @AdamJaggard
    AdamJaggard committed May 17, 2024
    Configuration menu
    Copy the full SHA
    b278b59 View commit details
    Browse the repository at this point in the history

  21. fix broken links after rebase onto nextjs upgrade

    @AdamJaggard
    AdamJaggard committed May 17, 2024
    Configuration menu
    Copy the full SHA
    99f1712 View commit details
    Browse the repository at this point in the history

  22. remove mode flipping hack, manually dispatch change event to update s… 

    …tate
    @AdamJaggard
    AdamJaggard committed May 17, 2024
    Configuration menu
    Copy the full SHA
    f4cb9a9 View commit details
    Browse the repository at this point in the history

  23. shared getTextTrack

    @AdamJaggard
    AdamJaggard committed May 17, 2024
    Configuration menu
    Copy the full SHA
    571e792 View commit details
    Browse the repository at this point in the history

  24. addChapters and addCuePoints to use one shared function

    @AdamJaggard
    AdamJaggard committed May 17, 2024
    Configuration menu
    Copy the full SHA
    b4ee78c View commit details
    Browse the repository at this point in the history

  25. oops, don't stringify strings!

    @AdamJaggard
    AdamJaggard committed May 17, 2024
    Configuration menu
    Copy the full SHA
    a00de2f View commit details
    Browse the repository at this point in the history

  26. demos more readable

    @AdamJaggard
    AdamJaggard committed May 17, 2024
    Configuration menu
    Copy the full SHA
    3aafd8a View commit details
    Browse the repository at this point in the history

  27. fix tests for webkit, don't skip cuepoints tests

    @AdamJaggard
    AdamJaggard committed May 17, 2024
    Configuration menu
    Copy the full SHA
    6561194 View commit details
    Browse the repository at this point in the history

  28. account for cuepoint values being strings and needing to be stringified

    @AdamJaggard
    AdamJaggard committed May 17, 2024
    Configuration menu
    Copy the full SHA
    a3d9aa1 View commit details
    Browse the repository at this point in the history

  29. fix(playback-core): Fix chapters and cuepoints edge case for active cue.

    @cjpillsbury
    cjpillsbury committed May 17, 2024
    Configuration menu
    Copy the full SHA
    5db3f62 View commit details
    Browse the repository at this point in the history

  30. test(mux-player): Cleanup async and event logic in tests (particularl… 

    …y chapters and cuepoints.
    @cjpillsbury
    cjpillsbury committed May 17, 2024
    Configuration menu
    Copy the full SHA
    79117f1 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Merge branch 'main' into feat/chapters

    @AdamJaggard
    AdamJaggard committed May 21, 2024
    Configuration menu
    Copy the full SHA
    0d7077f View commit details
    Browse the repository at this point in the history