Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add more test coverage #433

Merged
merged 4 commits into from Jan 20, 2023
Merged

test: add more test coverage #433

merged 4 commits into from Jan 20, 2023

Conversation

luwes
Copy link
Contributor

@luwes luwes commented Jan 12, 2023

No description provided.

@luwes luwes self-assigned this Jan 12, 2023
@vercel
Copy link

vercel bot commented Jan 12, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
media-chrome ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 20, 2023 at 10:37PM (UTC)
media-chrome-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 20, 2023 at 10:37PM (UTC)

@luwes luwes marked this pull request as ready for review January 13, 2023 22:20
@luwes luwes requested review from a team and heff as code owners January 13, 2023 22:20
cjpillsbury
cjpillsbury requested changes Jan 17, 2023
View reviewed changes
Copy link
Collaborator

@cjpillsbury cjpillsbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of suggestions. Otherwise, 😎

@vercel
Copy link

vercel bot commented Jan 20, 2023

@luwes is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

luwes and others added 4 commits January 20, 2023 16:35
@luwes @gkatsev
test: add AttributeTokenList tests
7680f29 
Co-authored-by: Gary Katsevman <git@gkatsev.com>
@luwes
test: add time spec
68f6354
@luwes @cjpillsbury
Update test/unit/utils/attribute-token-list.spec.js
eaad15f 
Co-authored-by: Christian Pillsbury <cjpillsbury@gmail.com>
@luwes @cjpillsbury
fix: removing non existing token
22bc6f5 
Co-authored-by: Christian Pillsbury <cjpillsbury@gmail.com>
cjpillsbury
cjpillsbury approved these changes Jan 20, 2023
View reviewed changes
Copy link
Collaborator

@cjpillsbury cjpillsbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@luwes luwes merged commit f6fbc8c into muxinc:main Jan 20, 2023
@luwes luwes deleted the more-tests branch January 20, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjpillsbury cjpillsbury cjpillsbury approved these changes

@heff heff Awaiting requested review from heff heff is a code owner

Assignees

@luwes luwes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@luwes @cjpillsbury