Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add Design Principles page #445

Merged
merged 4 commits into from Jan 26, 2023
Merged

Conversation

luwes
Copy link
Contributor

@luwes luwes commented Jan 21, 2023

@luwes luwes self-assigned this Jan 21, 2023
@vercel
Copy link

vercel bot commented Jan 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
media-chrome ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 24, 2023 at 10:32PM (UTC)
media-chrome-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 24, 2023 at 10:32PM (UTC)

@vercel
Copy link

vercel bot commented Jan 21, 2023

@luwes is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

@heff
Copy link
Collaborator

heff commented Jan 24, 2023

Should we split this into two? Maybe Design Principles and Architecture? While they overlap at "Connecting elements to the media" they feel like generally different concepts.

@luwes
Copy link
Contributor Author

luwes commented Jan 24, 2023

sounds good to me, will make some changes.

@luwes luwes changed the title docs: add notes to merged architecture page docs: Add Design Principles page Jan 24, 2023
Copy link
Collaborator

@dylanjha dylanjha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@luwes luwes merged commit 7c5868c into muxinc:main Jan 26, 2023
@luwes luwes deleted the architecture-docs branch January 26, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants