Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix contrast + sidebar style #576

Merged
merged 1 commit into from May 5, 2023
Merged

docs: fix contrast + sidebar style #576

merged 1 commit into from May 5, 2023

Conversation

luwes
Copy link
Contributor

@luwes luwes commented May 5, 2023

  • fix color contrast of left sidebar selection
  • align more to Mux docs sidebar styles

@luwes luwes requested a review from a team as a code owner May 5, 2023 16:50
@luwes luwes self-assigned this May 5, 2023
@luwes luwes requested a review from heff as a code owner May 5, 2023 16:50
@vercel
Copy link

vercel bot commented May 5, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
media-chrome ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2023 5:06pm
media-chrome-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2023 5:06pm

@codecov
Copy link

codecov bot commented May 5, 2023 •
edited

Codecov Report

Merging #576 (4adcdf5) into main (abb1738) will not change coverage.
The diff coverage is n/a.

❗ Current head 4adcdf5 differs from pull request most recent head 4e8be3b. Consider uploading reports for the commit 4e8be3b to get more accurate results

@@           Coverage Diff           @@
##             main     #576   +/-   ##
=======================================
  Coverage   77.98%   77.98%           
=======================================
  Files          42       42           
  Lines        7295     7295           
=======================================
  Hits         5689     5689           
  Misses       1606     1606

gkatsev
gkatsev approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@luwes luwes merged commit 0c754ef into muxinc:main May 5, 2023
4 checks passed
@luwes luwes deleted the docs-sidebar-style branch May 5, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkatsev gkatsev gkatsev approved these changes

@heff heff Awaiting requested review from heff heff is a code owner

Assignees

@luwes luwes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@luwes @gkatsev