New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update official themes to use lowercase attrs consistently. #623
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -31,7 +31,7 @@ template.innerHTML = /*html*/` | |||
color: var(--_primary-color); | |||
} | |||
|
|||
[disabled] { | |||
[disabled]:not(media-live-button) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE: media-live-button
is disabled
whenever not playing at the live edge and will automatically update its default cursor to not-allowed
, so excluding it from this styling so it doesn't have partial opacity under these conditions.
@@ -70,7 +70,7 @@ template.innerHTML = /*html*/` | |||
color: inherit; | |||
} | |||
|
|||
[disabled] { | |||
[disabled]:not(media-live-button) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE: media-live-button
is disabled
whenever not playing at the live edge and will automatically update its default cursor to not-allowed
, so excluding it from this styling so it doesn't have partial opacity under these conditions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice finds!
kebab-case
attrs in theme definitions.lowercase
instead ofkebab0case
for consistency (e.g.seek-forward-offset
is nowseekforwardoffset
)