fix: remove rendition order ascending (#43)

muxinc · May 8, 2024 · 68a25de · 68a25de
1 parent 604c2d3
commit 68a25de
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 10 deletions.
diff --git a/Sources/MuxPlayerSwift/PublicAPI/Options/PlaybackOptions.swift b/Sources/MuxPlayerSwift/PublicAPI/Options/PlaybackOptions.swift
@@ -53,8 +53,6 @@ public enum MinResolutionTier {
 public enum RenditionOrder {
     /// By default no rendition order is specified
     case `default`
-    /// The asset will choose renditions in ascending order
-    case ascending
     /// The asset will choose renditions in descending order
     case descending
 }
@@ -102,8 +100,6 @@ extension RenditionOrder {
         switch self {
         case .default:
             return ""
-        case .ascending:
-            return "asc"
         case .descending:
             return "desc"
         }

diff --git a/Tests/MuxPlayerSwift/PlaybackURLTests.swift b/Tests/MuxPlayerSwift/PlaybackURLTests.swift
@@ -105,14 +105,11 @@ final class PlaybackURLTests: XCTestCase {
         let expectedURLs: [String: String] = [
             RenditionOrder.descending.queryValue:
                 "https://stream.mux.com/abc.m3u8?redundant_streams=true&rendition_order=desc",
-            RenditionOrder.ascending.queryValue:
-                "https://stream.mux.com/abc.m3u8?redundant_streams=true&rendition_order=asc",
             RenditionOrder.default.queryValue:
                 "https://stream.mux.com/abc.m3u8?redundant_streams=true"
         ]
 
         let tiers: [RenditionOrder] = [
-            .ascending,
             .descending,
             .default
         ]
@@ -137,8 +134,7 @@ final class PlaybackURLTests: XCTestCase {
     func testMultiplePlaybackOptionParams() throws {
         let playbackOptions = PlaybackOptions(
             maximumResolutionTier: MaxResolutionTier.upTo2160p,
-            minimumResolutionTier: MinResolutionTier.atLeast1440p,
-            renditionOrder: RenditionOrder.ascending
+            minimumResolutionTier: MinResolutionTier.atLeast1440p
         )
 
         let playerItem = AVPlayerItem(
@@ -148,7 +144,7 @@ final class PlaybackURLTests: XCTestCase {
 
         XCTAssertEqual(
             (playerItem.asset as! AVURLAsset).url.absoluteString,
-            "https://stream.mux.com/abc.m3u8?redundant_streams=true&max_resolution=2160p&min_resolution=1440p&rendition_order=asc"
+            "https://stream.mux.com/abc.m3u8?redundant_streams=true&max_resolution=2160p&min_resolution=1440p"
         )
     }