Skip to content

Commit

Permalink
Releases/v3.4.7 (#356)
Browse files Browse the repository at this point in the history
## Fixes

* fix: ad metadata not collected for mid and postrolls (#354)
* fix: time-to-first-frame incorrect if user seeks before play starts (#355)



Co-authored-by: Emily Dixon <edixon@mux.com>
Co-authored-by: GitHub <noreply@github.com>
  • Loading branch information
daytime-em and web-flow committed Jan 8, 2024
1 parent b6b41e7 commit 91327fc
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
Expand Up @@ -76,16 +76,16 @@ class AdsImaSDKListener private constructor(
private fun setupAdViewData(event: MuxAdEvent, ad: Ad?) {
val viewData = ViewData()
val adData = AdData();
if (stateCollector.playbackPositionMills == 0L) {
if (ad != null) {
if (ad != null) {
if (stateCollector.playbackPositionMills < 1000L) {
viewData.viewPrerollAdId = ad.adId
viewData.viewPrerollCreativeId = ad.creativeId

exoPlayer?.getAdTagUrl()?.let { adData.adTagUrl = it }
ad.adId?.let { adData.adId = it }
ad.creativeId?.let { adData.adCreativeId = it }
ad.universalAdIdValue?.let { adData.adUniversalId = it }
}

exoPlayer?.getAdTagUrl()?.let { adData.adTagUrl = it }
ad.adId?.let { adData.adId = it }
ad.creativeId?.let { adData.adCreativeId = it }
ad.universalAdIdValue?.let { adData.adUniversalId = it }
}
event.viewData = viewData
event.adData = adData;
Expand Down
2 changes: 1 addition & 1 deletion build.gradle
Expand Up @@ -51,7 +51,7 @@ allprojects {
compileSdkVersion = 34
targetSdkVersion = 34

muxCoreVersion = "7.12.0"
muxCoreVersion = "7.13.0"
kotlinxCoroutinesVersion = "1.6.1"
}
}
Expand Down

0 comments on commit 91327fc

Please sign in to comment.