Increase default chunkSize to 30 MB #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This drastically improves performance on faster connections, at the cost of potentially needing to retry a larger chunk of data when a connection is interrupted. It's impossible to serve both fast and slow/unreliable internet connections well with a single fixed setting here, so in the future this should be made to scale dynamically to 1) maximize upload speed on fast connections, and 2) constrain the amount of time that will be wasted re-uploading a partial segment if it is interrupted.
jsanford8
approved these changes
Feb 24, 2022
|
I'll let you all decide if/when/how to merge and release this since it involves versioning and new npm releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drastically improves performance on faster connections, at the cost of potentially needing to retry a larger chunk of data when a connection is interrupted.
It's impossible to serve both fast and slow/unreliable internet connections well with a single fixed setting here, so in the future this should be made to scale dynamically to 1) maximize upload speed on fast connections, and 2) constrain the amount of time that will be wasted re-uploading a partial segment if it is interrupted.
I did not touch the version here, up to you how to deal with communicating this changed default.