Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark handleUpload as async #79

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Mark handleUpload as async #79

merged 1 commit into from
Apr 7, 2022

Conversation

davekiss
Copy link
Contributor

@davekiss davekiss commented Apr 7, 2022 •
edited
Loading

Noticed a small README bug while implementing in a new app, this function needs to be async in order to use the await keyword

@davekiss davekiss merged commit 81bc8fb into muxinc:master Apr 7, 2022
jaredsmith
jaredsmith approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@jaredsmith jaredsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredsmith jaredsmith jaredsmith approved these changes

@gkatsev gkatsev gkatsev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davekiss @jaredsmith @gkatsev