-
-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for different signing and verification certificates #822
base: main
Are you sure you want to change the base?
Conversation
…ackward compatibility is kept.
Codecov Report
@@ Coverage Diff @@
## master #822 +/- ##
==========================================
+ Coverage 89.37% 89.38% +<.01%
==========================================
Files 65 65
Lines 4774 4775 +1
Branches 831 831
==========================================
+ Hits 4267 4268 +1
Misses 327 327
Partials 180 180
|
Thanks. I don't think it's fully backwards compatible because kwargs are renamed. If we can keep those the same as now and only add a new optional keyword argument then i can merge it |
Will there ever be a case, other than testing via round-trip, where the certificate used for sending messages is the same as the one that signs received messages? |
@zanchey I build this originally for a use case were it was the case that the certificates were the same. If that is best practice I'm not sure :-) Either way, it should be pretty easy to keep this backwards compatible by not renaming the kwargs |
Hi! I confirm that this scenario is actually real with a bigger National ISP WS Thanks to all |
I have the same issue with a government SOAP api - signing and verification certificates are different. Any plans for this? |
Using the |
I added support for situations where the signing certificate is different from the response signature verification certificate.
The code added will is fully compatible with older versions, since the signature verification certificate will only be used if it is passed to the constructor - otherwise the signing certificate is used (same as used to be before the change).