Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React native 0.56+ support (iOS) #28

Merged
merged 4 commits into from Jul 30, 2018
Merged

React native 0.56+ support (iOS) #28

merged 4 commits into from Jul 30, 2018

Conversation

brunobar79
Copy link
Contributor

Just tried this with the latest version of React Native and it's giving me the following errors:

screen shot 2018-07-17 at 4 13 11 am

Steps to reproduce:

  • Create a new app using react-native init (react native 0.56+)
  • Install this library
  • Try to compile

This PR fixes the issue

@brunobar79 brunobar79 mentioned this pull request Jul 17, 2018
Merged
@mvayngrib
Copy link
Owner

@brunobar79 thanks for the PR!

would you mind adjusting the imports to the format here? They take into account a 3rd case

https://github.com/peggyrayzis/react-native-create-bridge/blob/master/templates/modules/ios-objc/Template.m

@brunobar79
Copy link
Contributor Author

@mvayngrib Good call. Just did it.

@brunobar79 brunobar79 changed the title React native 0.56+ support React native 0.56+ support (iOS) Jul 30, 2018
@mvayngrib mvayngrib merged commit ac5179c into mvayngrib:master Jul 30, 2018
@mvayngrib
Copy link
Owner

@brunobar79 cool, thanks! released in 3.5.0

@mvayngrib mvayngrib mentioned this pull request Jul 30, 2018
Closed
@modosc modosc mentioned this pull request Feb 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brunobar79 @mvayngrib