Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug on numbers #57

Merged
merged 2 commits into from Apr 20, 2018
Merged

fix bug on numbers #57

merged 2 commits into from Apr 20, 2018

Conversation

mvcds
Copy link
Owner

@mvcds mvcds commented Apr 20, 2018 •
edited

Proposed changes

Use another base for number-based types

Relates

Checklist

  • I have reviewed the most recent version of CONTRIBUTING to this repository
  • I have validated that lint and tests pass locally with my changes
  • I have added tests that prove the PR works (if appropriate)
  • I have covered at least 50% of the code
  • I have added necessary documentation (if appropriate)
  • I have merged the last version into my PR (if appropriate)
  • I have reviewed the PR and consider it to be small (to make reviewing it easier)
  • Select one from the following about your PR, it...
    • is a non-breaking change (patch)
    • adds functionality withouth breaking changes (minor)
    • cause existing functionalities to not work as expected (major)

@mvcds mvcds added the bug Something isn't working label Apr 20, 2018
@coveralls
Copy link

coveralls commented Apr 20, 2018 •
edited

Coverage Status

Coverage decreased (-0.3%) to 99.709% when pulling 7540ae6 on fix-joi-numbers into 3c0094d on master.

@mvcds mvcds merged commit b419af3 into master Apr 20, 2018
@mvcds mvcds deleted the fix-joi-numbers branch April 20, 2018 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mvcds @coveralls