Skip to content
This repository has been archived by the owner on Jun 9, 2021. It is now read-only.

add full filesystem tests #19

Closed
mvdan opened this issue Sep 21, 2017 · 1 comment
Closed

add full filesystem tests #19

mvdan opened this issue Sep 21, 2017 · 1 comment
Assignees
@mvdan

Comments

@mvdan
Copy link
Owner

mvdan commented Sep 21, 2017

We need test coverage for:

  • loading Go files (no types)
  • loading directories (no types)
  • loading packages (no types)
  • loading packages with types
  • printing of matches

Since we have unit tests for the matcher, these shouldn't cover all the match scenarios. But they should cover all the argument loading and stdout printing scenarios.
@mvdan mvdan self-assigned this Sep 21, 2017
mvdan added a commit that referenced this issue Sep 21, 2017
@mvdan
add loading of separate .go files without types
d0af506 
Wrote it in a way such that files and packages can be mixed in a single
list of arguments.

No tests yet, but verified manually. Filed #19 for the tests.

Fixes #6.
mvdan added a commit that referenced this issue Sep 22, 2017
@mvdan
add full tests using single Go files
57a36d0 
Updates #19.
mvdan added a commit that referenced this issue Sep 24, 2017
@mvdan
add full tests for local and wildcard pkgs
cd4179e 
And move gotool to the right place, using the right build.Context.

Updates #19.
@mvdan
Copy link
Owner Author

mvdan commented Sep 24, 2017

Happy for now. Will continue adding more to them as we go along.

@mvdan mvdan closed this as completed Sep 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mvdan mvdan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mvdan