parse: does not understand case fallthrough tokens

[nshalman]

shfmt is totally fine with this code:

#!/bin/bash

do_fallthrough() {

        case $1 in
                'foo')
                        echo foo
                        ;;
                'bar')
                        echo bar
                        ;;
                *)
                        echo baz
                        ;;
        esac
}

echo
do_fallthrough foo

echo
do_fallthrough bar

echo
do_fallthrough blah

But with this code:

#!/bin/bash

do_fallthrough() {

        case $1 in
                'foo')
                        echo foo
                        ;;
                'bar')
                        echo bar
                        ;&
                *)
                        echo baz
                        ;;
        esac
}

echo
do_fallthrough foo

echo
do_fallthrough bar

echo
do_fallthrough blah

I get this (I believe) erroneous error:
sample.sh:11:4: ; can only immediately follow a statement

Relevant Documentation:
https://www.gnu.org/software/bash/manual/bashref.html#index-case

[mvdan]

Ah, this is simply a bash token (not POSIX) that I hadn't added yet. Thanks for spotting!

[nshalman]

No problem. Thanks for sharing this code. Aside from that one token it was perfectly happy to apply a consistent style to a bunch of organically grown scripts that each contained multiple different styles.

If I were a stronger Go programmer and had more time I'd have tried to fix it myself and open a PR, but I figured a good bug report would still be appreciated.

Again, thanks for sharing your code!

[mvdan]

No problem. Thanks for sharing this code. Aside from that one token it was perfectly happy to apply a consistent style to a bunch of organically grown scripts that each contained multiple different styles.

Cool :)

If I were a stronger Go programmer and had more time I'd have tried to fix it myself and open a PR, but I figured a good bug report would still be appreciated.

Parsers become stupidly complex very easily, especially one that parses Shell. So no worries on that front - it's much easier for me to fix things like these as I'm already familiar with the codebase.

[nshalman]

Thanks for the quick fix! The new version no longer throws the error for me.
I packaged this tool for NixOS yesterday (NixOS/nixpkgs#16247) and will be updating the package to point to this code.

[mvdan]

@nshalman could you please update it to 0.2.0 there? Thanks!

[nshalman]

As shown above, I've created NixOS/nixpkgs#19524
Thanks for the reminder!
edit: It's been merged.

[mvdan]

@nshalman thanks!

[mvdan]

@nshalman please update to 1.1.0 :)

[nshalman]

PR created: NixOS/nixpkgs#21695
edit: merged.