Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: alpine images are getting pushed to a different repo #504

Closed
mvdan opened this issue Feb 13, 2020 · 1 comment · Fixed by #505
Closed

CI: alpine images are getting pushed to a different repo #504

mvdan opened this issue Feb 13, 2020 · 1 comment · Fixed by #505

Comments

@mvdan
Copy link
Owner

mvdan commented Feb 13, 2020

They're going to https://hub.docker.com/r/mvdan/shfmt-alpine, e.g. mvdan/shfmt-alpine:3.0.1, instead of https://hub.docker.com/r/mvdan/shfmt`, e.g. mvdan/shfmt:3.0.1-alpine.

If the worry is about latest, then we can simply publish the latest-alpine tag as well.

/cc @ArturKlauser @oliv3r

mvdan pushed a commit that referenced this issue Feb 13, 2020
We want the alpine container to show up as a tag, not as its own repo.

Fixes #504

Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
mvdan added a commit that referenced this issue Feb 13, 2020
The alpine images are now tags on the main docker repo, instead of their
own separate repo.

See #504.
@ArturKlauser
Copy link
Contributor

The "$DOCKER_BASE-alpine:$TAG" was intentional on my part since it seemed cleaner to put it in a separate DockerHub repo than just separate it by tags in the same repo. But if you prefer tags, that'll work too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants