Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

interp: randomize not found name in tests #738

Closed
creack opened this issue Oct 2, 2021 · 1 comment · Fixed by #821
Closed

interp: randomize not found name in tests #738

creack opened this issue Oct 2, 2021 · 1 comment · Fixed by #821
Labels
good first issue

Comments

@creack
Copy link

creack commented Oct 2, 2021

Very nit-picky, I just happened to have a binary called foo in my path, causing the tests to fail. It might be a good idea to randomize the name when checking for something not found or to use a more lengthy, unlikely-to-be-used name.

--- FAIL: TestRunnerRun (0.28s)
    --- FAIL: TestRunnerRun/#641 (0.01s)
        interp_test.go:2981: wrong output in "alias foo='bar baz'\ntype foo":
            want: "type: foo: not found\nexit status 1"
            got:  "foo is /home/creack/go/bin/foo\n"
@mvdan
Copy link
Owner

mvdan commented Oct 2, 2021

Oops, thanks for catching this :)

@stoovon stoovon mentioned this issue Oct 10, 2021
Closed
@stoovon stoovon mentioned this issue Mar 5, 2022
Merged
mvdan pushed a commit that referenced this issue Mar 18, 2022
@stoovon
intrp: replace foo/bar with longer names in the tests
d6da8ce 
This will avoid potential name collisions with existing "foo" or "bar"
names in $PATH or the current environment.

While here, update the README, as we now require Go 1.17 or later.

Fixes #738.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace foo/bar with longer names
Randomise not found name in tests
2 participants
@creack @mvdan