syntax: add a LangVariant parameter to Quote #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @andreynering @pwaller if you're up for a review :) |
andreynering
approved these changes
Sep 30, 2021
syntax/testdata/fuzz/FuzzQuote/25f36feab4af00bc4dfc3cf56da02b842b62ba8c5ac44862b5b3b776a0d519b4
Show resolved
Hide resolved
|
Thanks for the review :) Added more tests, moved the code to quote.go, and I've added a QuoteError type. |
|
One last pre-merge change: QuoteError.RuneOffset is now ByteOffset, because a rune offset isn't particularly helpful on its own. It's not even easy to slice the string to get to the concerning rune quickly, but you can do that with a byte offset. |
I had missed that $'' expansions are non-POSIX, and only implemented by Bash and mksh. So, in POSIX mode, we can't quote non-printable characters. Moreover, fuzzing uncovered that mksh implements \x differently, meaning that we require extra logic to follow its rules. Keep all the fuzz crashers that we found in the process. Since we've started having more edge cases that we can't quote, start returning an error in the API, with a QuoteError type. All it gives right now is a character position and a reason. Finally, document what versions of Bash and mksh we develop with. This matters, because some systems ship with very old versions, which can implement slightly different quoting or escaping rules. While at it, start using quicktest for the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(see commit message)