check: use "comma,ok" for all type assertions

[quasilyte]

Use "ok" to check against type assertion failure
everywhere for consistency.

Also s/point/ptr/ as "point" is not very common
abbreviation for pointer (it could be just "p" as well).

[mvdan]

All looks good, and yes, consistency is important.

Just FYI, the reason that x, _ := y.(T); if x == nil is sometimes better than x, ok := y.(T); if !ok is that you use one less variable, and you avoid the ok && x == nil case (which is an edge case).

But either is equally correct most of the time, as we should never have that edge case here. And, as you say, consistency :)

[quasilyte]

Just FYI, the reason that x, _ := y.(T); if x == nil is sometimes better than x, ok := y.(T); if !ok is that you use one less variable, and you avoid the ok && x == nil case (which is an edge case).

Thanks.

I wanted to get involved and found no real low hanging fruits, so did this. :)

[mvdan]

There are some ways to make the tool more precise, but I doubt there's any hanging fruit :)

If you want ideas, run the tool on the Go tree, and see if any warnings are wrong (false positives). Or if you find an unused parameter and the tool didn't find it, that should also be fixed (false negative).