update golang.org/x/tools, fix panic with type params

[mgabeler-lee-6rs]

When unparam is embedded into e.g. golangci-lint and a newer golang.org/x/tools version is picked up, it can panic when analyzing generic code. In the version of tools unparam currently uses, it doesn't see generic functions at all. But in the updated version it does, and asking for the size of a type parameter panics, because it is unknown / unknowable.

Example code that will trigger this panic w/o the fix:

package example

import (
    "context"
    "fmt"
    "time"
)

var RetryDelay = time.Minute

func RunWithRetries[T, U any](
	ctx context.Context,
	f func(ctx context.Context, value T) (U, error),
	value T,
) (U, error) {
	for {
		if result, err := f(ctx, value); err == nil {
			return result, nil
		} else {
			fmt.Printf("waiting %v to retry: %v\n", RetryDelay, err)
			delay := time.After(RetryDelay)
			select {
			case <-ctx.Done():
				return result, ctx.Err()
			case <-delay:
				// continue
			}
		}
	}
}

[mvdan]

Thanks! Please add a short test, see testdata/script/typeparams.txtar. It should crash without the fix.

[mgabeler-lee-6rs]

Updated, verified it passes with the fix and detects & reports the crash without it.

[mvdan]

fixing a test TODO at the same time - nice :)