Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xn-- TLDs in relaxed mode #27

Closed
uggyuggy opened this issue Jul 14, 2019 · 1 comment
Closed

xn-- TLDs in relaxed mode #27

uggyuggy opened this issue Jul 14, 2019 · 1 comment

Comments

@uggyuggy
Copy link

Hi,

Having a list of valid TLD is nice to limit false positives in relaxed mode.
However, the default list does contains by default only the punnycode version of the TLD but not the xn-- version of it (the IANA list contains only the xn-- version).

$ idn 联通
xn--8y0a063a
$
$ echo "test.联通" | xurls -r
test.联通
$ echo "test.xn--8y0a063a" | xurls -r
$

I would suggest having the default list composed with the 2 versions of IDN TLDs.

@mvdan
Copy link
Owner

mvdan commented Jul 15, 2019

Thanks, this makes sense. A PR is welcome - otherwise I'll get to this at some point soon.

@mvdan mvdan closed this as completed in 776b0d8 Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants