Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Fixes #24

Merged
merged 8 commits into from Aug 26, 2022
Merged

Various Fixes #24

merged 8 commits into from Aug 26, 2022

Conversation

chrisleduc
Copy link
Contributor

This PR contains fixes to the issues posted currently, which I've also experienced.
I did not update the pre-compiled json file.

This fixes the issue where an account may incorrectly be flagged as a Guest account because it contains the character Guest in its name.
Incorrect OrgScore Number inside the Fragment
Fixes an issue where the result of OrgScore 5.2.1 would always be counted as a failure because "MaxFailedAttempts" contains the text "Failed".
Added Instructions for the Upload Script (which permissions need to be enabled for the API connection to work)
@chrisleduc
Copy link
Contributor Author

Hi @mvdbent
I added an update to README.md because it took me a while to find the minimum required permissions for the File Upload to work. Hope it is helpful to others as well.

Best,
Chris

@mvdbent
Copy link
Owner

mvdbent commented Aug 26, 2022

Thanks, awesome work @chrisleduc

@mvdbent mvdbent merged commit 50d5cf7 into mvdbent:dev Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants