Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin has no behavior #6

Closed
micseydel opened this issue Nov 7, 2022 · 8 comments
Closed

Plugin has no behavior #6

micseydel opened this issue Nov 7, 2022 · 8 comments

Comments

@micseydel
Copy link

Describe the bug
Right-clicking shows no option to copy as HTML. Using Cmd+P to use the command results in nothing on my clipboard.

To Reproduce
Steps to reproduce the behavior:

  1. Attempt to copy
  2. Attempt to paste

Expected behavior
Pasting would show what was supposedly copied.

Desktop (please complete the following information):

  • OS: OS X 12.6
  • Version: Obsidian 1.0
@mvdkwast
Copy link
Owner

mvdkwast commented Nov 8, 2022

Hi @micseydel, thanks for taking the time to leave feedback.

I haven't been able to test this with OS X unfortunately, so I will to find someone to help me reproducing / analysing this one.

@mvdkwast
Copy link
Owner

mvdkwast commented Nov 9, 2022

Tested on OS X 10.15, couldn't reproduce, so I will need more information :

  • are there any error messages in the debug console ?
  • did you try multiple documents ? with what kind of content. If you can identify a document that doesn't work, please provide it in source view.
  • where did you paste it ?

Thank you

@micseydel
Copy link
Author

  • when I Cmd+P for "html" and hit enter there's nothing in the console, although the command is available
  • I tried several documents, links, no links, no change in behavior
  • I tried pasting in the Facebook Messenger desktop app as well as Gmail within Firefox

Just now I created a "Blank" note and put "t" in it and this is what I get when I paste it into Sublime text:

<!-- directives:[] -->
			<div id="content"></div>

I'm a SWE with little experience working with browsers or copy/paste from code. I don't know TS and hadn't used the Electron developer tools specifically before but you're welcome to give me a branch to look at even if you just want to pack it full of debug stuff. I definitely want to get into Obsidian plugins before long.

@mvdkwast
Copy link
Owner

Hi @micseydel ,

Would you mind trying the latest version ? I updated the way the copy is triggered, so the command should not appear anymore if you are not in an editor.

The title of the document is not copied, so you need to have something in the document to check it out.

If that doesn't work for you, I'll be glad to accept your offer to test an instrumented version !

@micseydel
Copy link
Author

Thanks for looping back around! I get "Copy as HTML: styles.css not found" on app.js:1 from that.

@mvdkwast
Copy link
Owner

Something seems wrong : this plugin doesn't require a styles.css file, and the label should say 'Copy document as HTML', not 'Copy as HTML'. There is another plugin that is called 'Copy as HTML', maybe you're looking at that one ?

Could you try installing it using BRAT in a clean vault ?

@luckman212
Copy link

Just adding a data point: I tested this plugin (v0.2.3) on macOS 13.0.1 / Obsidian 1.0.3 and it's working fine for me! No errors in the console.

@micseydel
Copy link
Author

You're right, wrong repo, sorry about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants