Fix #148 (UB in try_call_once)
#149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, this change looks correct to me (I also came to a similar conclusion after seeing your issue). It looks like the MSRV check failed, so that will need fixing before merge. It seems like this issue has been in the crate for a while and will require the yanking of 3 versions ( |
|
Ok the MSRV issue should be fixed. I also cleaned up the impl to decrease nesting and remove some extra branching, but not sure if that's out of scope of this PR. |
|
Thanks, that's ideal! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #148 by retrying if the called-once function returns an error while another thread is also attempting to call a function.