Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Security Policy #156

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Create Security Policy #156

merged 1 commit into from
Sep 26, 2023

Conversation

diogoteles08
Copy link
Contributor

Closes #155

I've created the SECURITY.md file following a GitHub's template and considering that you'd request that users report vulnerabilities through security advisory, which is a handy new GitHub feature, but it's still in beta and has to be manually enabled by a maintainer.

If you're interested in this feature, you can activate it following this steps:

  1. Click on this link to go to Code security & analysis section on your repo's settings
  2. Click "Enable" for "Private vulnerability reporting (Beta)"

However, if you'd rather not use this feature, you can also request users to report vulnerabilities to an email. If that's the case, let me know which email you would like to receive the reports and I can submit the change.

Additionally, feel free to edit or suggest any changes to this document, it is supposed to reflect the amount of effort the team can offer to handle vulnerabilities.

@diogoteles08
Copy link
Contributor Author

Hey! This issue/PR has been idle for quite some time. Do you plan on considering these changes? If not, I'll probably wait up to 2 more months and close the issue.

Thanks!

@zesterer
Copy link
Collaborator

Hello. This PR got lost under a long backlog. Although I'm the maintainer of spin-rs, I (obviously) don't own the repository: will security reports get sent to me also?

@diogoteles08
Copy link
Contributor Author

Hey @zesterer! Yep, Github documentation states that "Anyone with admin permissions to a repository can see, review, and manage privately-reported vulnerabilities for the repository.", so you as a maintainer would be able to see it and would probably be notified as well. Does that answer your question?

@zesterer
Copy link
Collaborator

It does, yes. Thank you.

@zesterer zesterer merged commit 2cc9ee6 into mvdnes:master Sep 26, 2023
5 checks passed
@diogoteles08
Copy link
Contributor Author

Hey @zesterer, although the PR was merged, I think you haven't yet enabled the github's feature of Private Vulnerability Report, have you? If not, please follow the instructions I sent here and enable it.

When this feature is not enabled, the link pointed on your Security Policy will lead to Not Found :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a Security-Policy
2 participants