Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complement template #12

Closed
wants to merge 9 commits into from
Closed

Complement template #12

wants to merge 9 commits into from

Conversation

zorandir
Copy link
Collaborator

Create a ExceptionTemplate operation solving the issue #11;
Solve the issue #10 for binaries templates.

@mverardo
Copy link
Owner

Hey Zorandir, thank you a lot for your contribution!

I looked quickly at the the code, and found a couple of issues.

First, the "usage" docsStrings of the new functions are full of StyleBoxes.
I can't read them in my Mathematica installation. =/
Could you remove all formatting from the docStrings, please?

Also, as a general best practice, long expressions such as:

Apply[Or,#&/@Map[Part[#,1]==1-(Part[#,2])&,Select[MapThread[If[#1===#2,"X",#1==#2]&,{BaseTemplate[2,r],t}],Not[#==="X"]&]]]

...should be divided into private functions, or variables using Module.

I'm gonna try out ExceptionTemplate and ComplementTemplate and let you know if I find any issue.

@mverardo mverardo self-assigned this May 6, 2015
@mverardo mverardo closed this May 6, 2015
@mverardo
Copy link
Owner

mverardo commented May 6, 2015

Zorandir, I made a few changes to the code, and merged it with this technique.

I thought this pull request would be closed as merged, but I guess I was wrong.

I'm gonna close this one, but all your commits are in the project's history squashed into c438cf1.

Thanks for the contribution! =]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants