Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failing for 3.6 #138

Closed
dericke opened this issue Mar 4, 2021 · 2 comments · Fixed by #141
Closed

Test failing for 3.6 #138

dericke opened this issue Mar 4, 2021 · 2 comments · Fixed by #141

Comments

@dericke
Copy link
Contributor

dericke commented Mar 4, 2021

My use of datetime.strptime() in #134 relied on a Python 3.7+ feature, something I didn't realize until seeing the failing 3.6 tests today. Would it be better to drop 3.6 support, or should I refactor to remove the 3.7 dependency?
@dericke dericke changed the title Build failing for 3.6 Test failing for 3.6 Mar 4, 2021
@mvexel
Copy link
Owner

mvexel commented Mar 5, 2021

I would be okay with dropping support for 3.6, I think it reaches some EOL by the end of '21 anyway.

@dericke dericke mentioned this issue Mar 5, 2021
Closed
@dericke dericke mentioned this issue Mar 15, 2021
Merged
@Vitalts
Copy link

Vitalts commented Sep 7, 2021

Here added fix for 3.6 #144

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mvexel @Vitalts @dericke