-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements in Accessibility #123
Improvements in Accessibility #123
Conversation
I think it would be better to also change the URL when we enter a specific dialect, for example: dialetus.com/baianes
dialetus.com/mineires What do you think? |
@mvfsillva I like this idea, but, I believe that is not a part from PR. Would be necessary create another PR with this implementation. What do you think? |
Yes, I'll create a new issue for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing @emanuelgsouza thank you!
Pre-Submission Checklist
yarn test
andyarn lint
.Description
This PR implements a some improvements in Accessibility based on #116 ISSUE. So, the following changes are:
resolve #123