Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in Accessibility #123

Merged
merged 6 commits into from
Oct 18, 2019
Merged

Improvements in Accessibility #123

merged 6 commits into from
Oct 18, 2019

Conversation

emanuelgsouza
Copy link
Contributor

@emanuelgsouza emanuelgsouza commented Oct 8, 2019

Pre-Submission Checklist

  • You have only one commit (if not, squash them into one commit).
  • All new and existing tests pass the command yarn test and yarn lint.

Description

This PR implements a some improvements in Accessibility based on #116 ISSUE. So, the following changes are:

  • Add title tag in HEAD with 'Dialetos Brasileiros' text
  • Add label and placeholder in search input
  • Add lang attribute in html tag

resolve #123

@emanuelgsouza emanuelgsouza changed the title Feature/acessibility issues Improvements in Accessibility Oct 8, 2019
pages/_document.js Outdated Show resolved Hide resolved
pages/index.js Outdated Show resolved Hide resolved
@mvfsillva
Copy link
Owner

I think it would be better to also change the URL when we enter a specific dialect, for example:

dialetus.com/baianes
dialetus.com/mineires

What do you think?

@emanuelgsouza
Copy link
Contributor Author

@mvfsillva I like this idea, but, I believe that is not a part from PR. Would be necessary create another PR with this implementation. What do you think?

@mvfsillva
Copy link
Owner

@mvfsillva I like this idea, but, I believe that is not a part from PR. Would be necessary create another PR with this implementation. What do you think?

Yes, I'll create a new issue for this.

Copy link
Owner

@mvfsillva mvfsillva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing @emanuelgsouza thank you!

@mvfsillva mvfsillva merged commit 1c045da into mvfsillva:master Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants