Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix writeaccess() for user/group names with spaces in it #30

Merged
merged 1 commit into from
Mar 20, 2018
Merged

Fix writeaccess() for user/group names with spaces in it #30

merged 1 commit into from
Mar 20, 2018

Conversation

hstock
Copy link
Contributor

@hstock hstock commented Mar 20, 2018

I encountered a bug because my default group on my work PC is "Domain Users". Therefore the output from stat is split in the wrong way.

I fixed this by changing the delimiters to TAB-characters and setting IFS to TAB temporarily.

@mviereck mviereck merged commit 58baa3a into mviereck:master Mar 20, 2018
@mviereck
Copy link
Owner

Thank you!

@mviereck
Copy link
Owner

Can you check your output of id in container? I assume the group name will be Domain instead of Domain Users. Though, does not hurt, and I will fix that, too.

mviereck added a commit that referenced this pull request Mar 20, 2018
# 20.03.2018 V3.9.7.2   #30 Fix writeaccess() for user/group names with spaces in it
# 19.03.2018            --wm: fall back to autodetection if specified window manager not found
#                       bugfix --env: regard whitespace. Still need to handle special chars like"\'$.
#                       --add: new option to add a host command in xinitrc
# 18.03.2018            consolekit: enable and use automatically for --dbus-system, --openrc, --runit
#                       --dbus: enable automatically for --runit, --openrc
#                       mywatch(): watch again, now without sh -c
# 16.03.2018            --debug: new option to set -x in all scripts showing code lines while executed.
#                       --sharewayland, --waylandenv: deprecated, not needed for anything anymore. --wayland does the job.
#                       --help: usage() cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants