Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failure to unregister animation tick #21

Closed
mvindahl opened this issue Oct 12, 2014 · 1 comment
Closed

Failure to unregister animation tick #21

mvindahl opened this issue Oct 12, 2014 · 1 comment
Labels
bug

Comments

@mvindahl
Copy link
Owner

As reported by @equus71, the directive fails to unregister its animation tick from jQuery.fx when the directive is moved off the page. This has very real implications when using ngRoute since angular routing does just that ...

This issue is serious enough to justify a new bower release once it has been fixed.
@mvindahl mvindahl added the bug label Oct 12, 2014
mvindahl added a commit that referenced this issue Oct 12, 2014
@mvindahl
Fix for issue #21: Failure to unregister animation tick when directiv…
8c1eff2 
…e was removed from page
@mvindahl
Copy link
Owner Author

Fixed it. Writing the karma test was the tricky part. Will fix the slightly related issue #3 while I'm at it, then do a bower release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mvindahl