Interpolated id fix and more #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADDED: karma test to cover this case ADDED: config.inverMouseWheel option that will invert mousewheel direction if set to true (defaults to false)
|
Thanks for the contributions, warpdesign. Looks like some very nice improvements. I also like the style of your code :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did the following updates:
FIXED: changeZoomLevel signature [README.md]
FIXED: using an angular binding (id={{myId}}) for panzoomId didn't work …
ADDED: karma test to cover this case
ADDED: config.inverMouseWheel option that will invert mousewheel direction
if set to true (defaults to false)
UPDATED: bin files with a copy of build files (guess there's no gulp task for that ?)
I also fixed a couple of jshint errors, no idea if I introduced them or if they were there before.